Skip to content

Unify receivers used for 'executor' struct in ./executors/docker/

Tomasz Maczukin requested to merge unify-receiver-names-for-docker-exporter into master

What does this MR do?

Cleanup receivers used for executor struct.

Why was this MR needed?

Currently for the executor struct in gitlab.com/gitlab-runner/executors/docker package we were using two receivers:

  • func (s *executor)
  • func (e *executor)

While it of course works, in some IDEs (e.g. GoLand by JetBrains that I'm using) it was reported as a style violation. Since in executor_docker.go we have a lot methods defined for executor, it was making the usage of some IDE features very hard (e.g. highliting the lines where selected method/field is used).

This MR unifies the receivers to use func (e *executor) only in this package.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Edited by Kamil Trzciński

Merge request reports