Skip to content

edit GitLab Runner license info for Licensee

Andrea Kao requested to merge eirinikos/gitlab-runner:update-license into master

(CCing @dankohn who has requested this work so that the license will appear correctly in https://landscape.cncf.io/selected=git-lab-runner)

What does this MR do?

This commit updates the LICENSE file so that it contains only the exact text of the MIT license. It moves the reference to Creative Commons licensing (for the docs) to the README.

Why was this MR needed?

GitHub uses a library called Licensee to identify a project's license type. It shows this information in the status bar and via the API if it can unambiguously identify the license.

These changes allow Licensee to successfully identify the license type of GitLab Runner's codebase as MIT, which then allows GitHub's UI to show the repo's license type as MIT.

For comparison purposes, here is the output that I get when I run Licensee locally on GitLab Runner's remote repo on GitHub:

$ licensee detect https://github.com/gitlabhq/gitlab-runner
License:        Other
Matched files:  LICENSE, README.md
LICENSE:
  Content hash:  5355321f04ead6b937cfb74875c926a76a85893d
  Attribution:   Copyright (c) 2015-2018 GitLab B.V.
  License:       Other
  Closest licenses:
    MIT similarity:      92.39%
    NCSA similarity:     78.18%
    BSL-1.0 similarity:  66.36%
README.md:
  Content hash:  6e00ad53a170d749fc8c1cc1cb82e7321858ab87
  Confidence:    90.00%
  Matcher:       Licensee::Matchers::Reference
  License:       MIT License
  Closest licenses:
    WTFPL similarity:      17.02%
    Unlicense similarity:  8.26%
    BSL-1.0 similarity:    8.26%

And here is the output that I get when I run Licensee on the update-license branch of my local GitLab Runner clone:

$ licensee detect ../gitlab-runner
License:        MIT License
Matched files:  LICENSE, README.md
LICENSE:
  Content hash:  46cdc03462b9af57968df67b450cc4372ac41f53
  Attribution:   Copyright (c) 2015-2018 GitLab B.V.
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       MIT License
README.md:
  Content hash:  64e5677abe51ecf24975daf6112746b7f4943325
  Confidence:    90.00%
  Matcher:       Licensee::Matchers::Reference
  License:       MIT License
  Closest licenses:
    WTFPL similarity:      18.75%
    Unlicense similarity:  13.04%
    BSL-1.0 similarity:    13.04%

Are there points in the code the reviewer needs to double check?

No.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

There are no related issue numbers, but GitLab CE MR 18291 and MR 18981 are related to this MR.

Edited by Andrea Kao

Merge request reports