Skip to content

Add BOM to make powershell happy with utf-8 characters.

Yuankai Zhang requested to merge ykzhangyitu/gitlab-runner:patch-2 into master

This is a general Merge Request template. Consider to choose a template from the list above if it will match your case more.

What does this MR do?

Add BOM to generated powershell script, making powershell correctly recognize the encoding as utf-8.

Why was this MR needed?

Non-ASCII character in GITLAB_USER_NAME may cause build to failed without this patch.

Are there points in the code the reviewer needs to double check?

The "\uFEFF" will be correctly translate to byte sequence 0xEF,0xBB,0xBF when writing to the script.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Not exists.

Edited by Yuankai Zhang

Merge request reports