Skip to content

Temporary add 'retry: 2' for 'unit tests (no race)' job

Tomasz Maczukin requested to merge temporary-improvement-for-failing-job into master

What does this MR do?

Adds retry: 2 configuration setting for unit tests (no race) job.

Why was this MR needed?

We have a randomly failing test in the unit tests (no race) job. While I still haven't got time to dig into this, the failing test is annoying.

It fails randomly, which:

  • affects release process (yesterday I've pushed v10.7.0 before I left my home, and after getting back after few hours, I've realized that the release pipeline failed on this test and the v10.7.0 packages were not published)
  • makes it harder to work with contributors (If the MR is good, but the test is failing we need to ask the contributor for a retry and wait until he'll notice this and eventually retry the job),
  • makes the Merge when pipeline succeeds to not work as one could expect to (you push the button, you close the browser tab... and two days later you realize that the MR is still not merged, because the test failed).

While we should generally find out why the test is failing and how to improve it, I've decided to add this small change to just improve the usability of our pipeline in current stage. I've noticed, that in most cases the job passes after a retry (sometimes it needs two), so using our retry: X feature seems to be the fastest solution right now.

Are there points in the code the reviewer needs to double check?

Not really ;)

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Merge request reports