Skip to content

Update interfaces mocks

Tomasz Maczukin requested to merge update-interfaces-mocks into master

What does this MR do?

  1. Excludes vendor/ from command that deletes existing mocks.
  2. (Re)generates few of existing mocks.

Why was this MR needed?

  1. Currently calling make mocks removes files from vendor/ and doesn't regenerate them. This is not good, because we should not commit changes in vendor/ manually, and it's quite easy to forget to remove these changes before doing git add . and git commit.
  2. Apparently a mock for one of the interfaces was never generated, and two of them were not updated after interface changes. I noticed this when working with one of the mocks recently. This MR updates these mocks, so next time when someone will execute make mocks, it should update only mocks related to the MR.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Merge request reports

Loading