The source project of this merge request has been removed.
Fixes #2338: k8s entrypoint configuration
This is a general Merge Request template. Consider to choose a template from the list above if it will match your case more.
What does this MR do?
Fixes #2338 (closed)
Why was this MR needed?
gitlab-runner should respect the ENTRYPOINT from the Dockerfile if no entrypoint is definied in the gitlab-ci.yml file
Are there points in the code the reviewer needs to double check?
Sure. First time contribution, no golang experience.
But I test the Build on our gitlab infrastructure https://hub.docker.com/r/jkroepke/gitlab-runner and I got no problems.
Known Issues:
- Secret variables are not available if ENTRYPOINT is executed. Because they are not defined/included in the Pod Manifest for the runner pod. See https://gitlab.com/gitlab-org/gitlab-runner/blob/master/executors/kubernetes/executor_kubernetes.go#L195
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if you do - rebase it please)
What are the relevant issue numbers?
Edited by Jan-Otto Kröpke