Skip to content

Change confusing Built value for development version

Tomasz Maczukin requested to merge update-version-info into master

What does this MR do?

Changes the way how GitLab Runner presents the BuiltAt time for development version.

Why was this MR needed?

If someone is compiling the development version not using our Makefile targets, the version info is currently returning a current execution time when gitlab-runner --version is called. This mean that two subsequent gitlab-runner --version executions will print different BuiltAt time for the same binary, and each time this will be a current user's time.

In most scenarios this may be confusing (as reported in #3051 (closed), which was created after discussing #3039 (closed)).

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #3051 (closed)

Merge request reports