Use short alias in service health check container
What does this MR do?
Shortens the alias name of a service container to "service" inside the service health check container. This change should have no side effects, as only one service container is linked at a time during health check, and the aliases in the build container are handled differently anyways.
Why was this MR needed?
Background: After moving our repositories from gitlab.com to our private gitlab-ee instance, we started getting warnings that service containers based on images from our own registry probably didn't start up, as the health check containers were exiting with 1. Linking the same service containers from the global docker registry did not show this error. Running docker inspect on the health check containers revealed that link strings in the form of container_name:alias seem to be truncated to a length of 255 characters.
By using the short alias during health check we avoid hitting this character limit when the registry sits behind a long domain name and the service images are produced in repositories of subgroups.
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master(if you do - rebase it please)