Skip to content

Fix git 1.7.1 compatibility in executors/shell package tests

Alessio Caiazza requested to merge test_centos_6 into master

What does this MR do?

This MR introduces a new test job that will run go test gitlab.com/gitlab-org/gitlab-runner/executors/shell gitlab.com/gitlab-org/gitlab-runner/shells on a CentOS/6 image with git v1.7.1

It also fixes all the test incompatibilities and skip tests that cannot be run on git 1.7.x

Why was this MR needed?

We support CentOS/6 and it ships with git v1.7.1.

This new jobs ensures that we are generating shell scripts that executorshell can when git v.17.1 is available.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

#2991 (closed) #2992 (closed)

Edited by Alessio Caiazza

Merge request reports