Skip to content

Increased timeout times to solve issue #2408

MBcom requested to merge MBcom/gitlab-runner:master into master

What does this MR do?

Added higher timeouts in common/const.go, vendor/github.com/docker/go-connections/sockets/sockets.go and helpers/docker/sockets.go to avoid jobs being aborted, when docker daemon can not connect to docker.sock. This solves issue #2408 (closed).

Why was this MR needed?

This MR is needed because jobs which are using additional services like postgres, often (80-90%) fail with the error message: Cannot connect to unix:///var/run/docker.sock. Is the docker daemon running?.

Are there points in the code the reviewer needs to double check?

Maybe check, why "unit test (no race)" fails sometimes. In our production checks this error is not important for stability concerns, but it is not nice. Other checks are ok.

  • Documentation created/updated
  • Tests
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

#2408 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports