Skip to content

Re-generate Mocks with Mockery v1.0.0

Lorenzo Villani requested to merge (removed):regen-mocks into master

What does this MR do?

This MR re-generates all test mocks with mockery 1.0.0

Why was this MR needed?

While working on !734 (merged) we found out that the latest version of mockery breaks code quality checks by introducing golint errors.

Are there points in the code the reviewer needs to double check?

  • This MR is a bit noisy since there's a commit in which we re-generate all mocks using the latest version of mockery, it's probably best to individually review each commit.
  • The top-most commit vendors the current version of mockery in the vendor directory. It is a bit of an hack and most probably a misuse of govendor (which AFAIK isn't designed to vendor CLI executables) and relies on a series of "happy coincidences" (e.g. the mockery CLI is a single .go file that is go run-able). It can be dropped if it impacts maintainability.

Merge request reports