Skip to content

Stop Docker Machine before removing it

Tomasz Maczukin requested to merge stop-machine-before-removing into master

What does this MR do?

Adds a docker-machine stop step before removing machine.

Why was this MR needed?

Currently we're doing only docker-machine rm which is roughly destroying a machine. This doesn't shutdown machine properly so anything that is done on the shutdown of machine (e.g. disconnecting from a Consul cluster) is not executed.

Adding docker-machine stop step should make the machine to be powered off gracefully, with execution of all shutdown handlers.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Edited by Tomasz Maczukin

Merge request reports