Restore Localization section header in CODEOWNERS

Lauren Barkerrequested to merge
fix/codeowners-localization-section-header into main

What does this MR do?

Changes the ## Localization comment in .gitlab/CODEOWNERS back into a real section header, [Localization].

Why was this MR needed?

Root cause

CODEOWNERS recognises sections only when they are declared as [Section]. Lines beginning with # are comments. Commit ee143728 removed the [Localization Team] header and left only the Markdown-style ## Localization heading above the localization entries, so those entries are parsed as part of the preceding [Documentation] section:

[Documentation]
.markdownlint.yml @gitlab-com/runner-docs-maintainers
/docs/ @gitlab-com/runner-docs-maintainers

## Localization        <- comment, not a section header
/docs-locale/ @gitlab-com/localization/maintainers/tech-docs
...

Impact

  • Within a section only the last matching entry applies, so a merge request that changes both docs/ and docs-locale/ requires approval from a single owner set instead of both the Runner docs maintainers and the localization maintainers.
  • Code owner approval rules generated for docs-locale/ paths report their section as Documentation. Automation that keys on the section name reads across the two groups as a result. The triage-ops AutomatedReviewRequestDoc processor selects a reviewer from code_owner rules whose section matches /\ADocumentation|\ADocs/, so localization maintainers land in the documentation reviewer pool for community documentation merge requests, and translation merge requests are attributed to the documentation section rather than to localization.

Fix

Declaring [Localization] as a section header scopes the docs-locale/ and argo_translation.yml entries again, restores independent approvals for the two owner sets, and gives localization rules a section name that documentation automation does not match. The section name deliberately avoids a Documentation/Docs prefix.

What's the best way to test this MR?

After merge, on a merge request that changes a file under docs-locale/, check the approval rules:

curl --header "PRIVATE-TOKEN: $TOKEN" \
  "https://gitlab.com/api/v4/projects/250833/merge_requests/<iid>/approval_rules"

The rule matching the docs-locale/ path reports "section": "Localization" instead of "section": "Documentation". On a merge request that changes both docs/ and docs-locale/, both owner sets are requested.

What are the relevant issue numbers?

None. Found while investigating an unexpected documentation review request on !7020 (merged).

Merge request reports