Resolve shell script issues flagged by shellcheck

Daniel Keenanrequested to merge
resolve-shellcheck-issues into main

What does this MR do?

  • Resolves shell script issues flagged by shellcheck.
  • Enforces shell:lint as a hard gate in CI (removing allow_failure: true).

Why was this MR needed?

  • To improve code quality in our shell scripts.
  • To ensure shellcheck failures block pipelines rather than silently passing as warnings.

What's the best way to test this MR?

  • Run make lint-shell and check that no issues are reported.
  • Verify that the CI shell:lint job passes green.

What are the relevant issue numbers?

Follow-up from #9524 (closed)

Edited by Daniel Keenan

Merge request reports