Resolve "GitLab Runner http endpoint should default to 9252"
This is a general Merge Request template. Consider to choose a template from the list above if it will match your case more.
What does this MR do?
Defaults the MetricsServer Port to 9252 as discussed in #2454 (closed).
Why was this MR needed?
Are there points in the code the reviewer needs to double check?
I don't really like the way I had to handle the error of net.SplitHostPort
, maybe you have a better idea on how to do that. The only alternative i can think of is maybe using url.Parse
instead.
Does this MR meet the acceptance criteria?
-
Documentation created/updated - Tests
-
Added for this feature/bug -
All builds are passing
-
-
Branch has no merge conflicts with master
(if you do - rebase it please)
What are the relevant issue numbers?
Closes #2454 (closed)
Edited by Jan Christophersen