Skip to content

Restore cache before artifacts

Tomasz Maczukin requested to merge improvement/restore-cache-before-artifacts into master

What does this MR do?

Makes cache to be restored before artifacts.

Why was this MR needed?

There can be a situation when someone - by mistake or by purpose - will configure the same path to be both cached and used as an artifact. Since artifacts are designed to be used to pass files between stages of a pipeline, and cache is designed to be 1) passed between different jobs in different stages (depended on user's configuration) and 2) are provided as "available in best case" feature, we should ensure that a proper file downloaded as an artifact will be not overwritten by a - for example - older file from another pipeline, downloaded with cache.

Please read #2379 (closed) for a reference and example of such issue.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Changed for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #2379 (closed)

Merge request reports