Gracefully handle missing informer permissions

Hannes Hörlrequested to merge
hhoerl/catch-external-pod-disruptions into main

What does this MR do?

Gracefully handle missing informer permissions

Instead of using a feature flag to guard against missing RBAC rules, we can check if we have relevant permissions.

Why was this MR needed?

This allows us to release this feature without a feature flag.

What's the best way to test this MR?

  • default:
    • run a build with the "default" RBAC rules
    • see that it works
  • without list permission
    • remove the "list" permission from the pod RBAC rules
    • run a build
    • see that it works¹
    • see that it prints a warning about missing permissions

¹ It might still fail on external pod disruption, which might only be caught in time when running with the informers

What are the relevant issue numbers?

Edited by Hannes Hörl

Merge request reports