Fix docker network config for Windows (!5182) · Merge requests · GitLab.org / gitlab-runner · GitLab

What does this MR do?

Fixes a regression introduced in >= 17.5 for docker network config on Windows.

For Windows and Docker with an API version >= 1.44, we accidentally assume that the default network is bridge (as is the case for Linux).

On Windows, the default is nat. The use of network.NetworkDefault provides a platform-independent alias.

What's the best way to test this MR?

Run: go test -run TestBuildLogLimitExceeded/successful_job -tags integration .\executors\docker\ on Windows with the latest Docker.

Before this MR: network bridge not found With this MR: ✅

What are the relevant issue numbers?

Closes #38267 (closed)