Stop testing UseWindowsLegacyProcessStrategy for KillerTest

Stan Hurequested to merge
sh-stop-testing-windows-legacy-process-strategy into main

What does this MR do?

We were seeing high rates of test failures in https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/8145006347. This appears to be happening when:

  1. UseWindowsLegacyProcessStrategy was enabled in the test.

  2. The tests in gitlab.com/gitlab-org/gitlab-runner/executors/shell and gitlab.com/gitlab-org/gitlab-runner/helpers/process run concurrently.

As described in !4659 (merged), killing a job with UseWindowsLegacyProcessStrategy also sends the signal to the Go interpreter.

Avoid these flaky test failures by removing these kill tests with UseWindowsLegacyProcessStrategy.

Edited by Stan Hu

Merge request reports