Fix home directory detection
What does this MR do?
Fix home directory detection
With 452ac0a2 we changed how HOME directory detection and "fixing" is working, but now it's causing runner to fail in cases it didn't before.
The change was done because previously we've been using a deprecated
function from the homedir
package. It was, however, done wrong.
This commit reverts code to a previous version.
Why was this MR needed?
What's the best way to test this MR?
What are the relevant issue numbers?
Merge request reports
Activity
added Category:Runner Core devopsverify grouprunner sectionci labels
assigned to @tmaczukin
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @josephburnett
(UTC-7, 9 hours behind author)
@ratchade
(UTC-4, 6 hours behind author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@tmaczukin
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added typebug label
requested review from @ajwalker
mentioned in incident gitlab-com/gl-infra/production#18732 (closed)
@ajwalker, do you mind setting MWPS in addition to the approval?
added regression regression:17.5 labels
changed milestone to %17.6
mentioned in merge request !5088 (merged)
mentioned in commit fe934fc9
mentioned in commit 0a56126e
changed milestone to %17.5
mentioned in issue #38252 (closed)
mentioned in issue #38276 (closed)
mentioned in issue #38270 (closed)
mentioned in merge request jointeg/infrastructure/compose-services!113 (merged)
changed milestone to %17.6