Skip to content

Suppress golangci-lint config deprecations and warnings

Joe Shaw requested to merge joeshaw/cleanup-golangcilint-warnings into main

What does this MR do?

Suppresses golangci-lint config deprecations and warnings that you see when running make lint.

Moves skip-dirs and skip-files under issues (deprecated location).

Removes gocritic already enabled linters to hide warnings.

Removes all other default settings for consistency.

Why was this MR needed?

Removes noisy WARN statements when running the go linter.

e.g. every code_quality job will contain:

level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`."
level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`."
level=warning msg="[linters_context] gocritic: no need to enable check \"badCall\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"badCond\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"codegenComment\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"commentFormatting\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"deprecatedComment\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"exitAfterDefer\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"flagName\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"newDeref\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"offBy1\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"underef\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"valSwap\": it's already enabled"
level=warning msg="[linters_context] gocritic: no need to enable check \"wrapperFunc\": it's already enabled"

What's the best way to test this MR?

make lint

What are the relevant issue numbers?

Edited by Joe Shaw

Merge request reports