Skip to content

Shorten network names created by FF_NETWORK_PER_BUILD

Ricardo Katz requested to merge rikatz/gitlab-runner:shorten-network-name into main
  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA

What does this MR do?

Shorten network names created by FF_NETWORK_PER_BUILD

Why was this MR needed?

Previously the creation of a network name by docker executor had extra unnecessary words, like "concurrent" and "network". This made the 63 character limits hit multiple times on projects with ID bigger than 100k and more than 1M job executions. The bigger problem here is that once this happens, solving the DNS to CI services created on the same network fails.

After this change, there is a reduction of at least 22 characters, leaving more room for bigger IDs and future improvements on the network name

What's the best way to test this MR?

This MR changes were picked on one of my runners, and I have tagged jobs to run specifically on it, getting all of the containers to be able to solve the DNS queries

What are the relevant issue numbers?

#27763

Edited by 🤖 GitLab Bot 🤖

Merge request reports