Skip to content

Rename ssh.Config to common.SshConfig to avoid misleading config.toml validation error

Romuald Atchadé requested to merge ssh-error-in-config-toml into main

What does this MR do?

When creating the schema for validating the config.toml, the ssh.Config is mistaken with common.Config, leading to a misleading validation error in the Runner Log.

This MR renames the ssh.Config type to common.SshConfig to prevent this reflector config confusion.

Why was this MR needed?

To avoid printing misleading error in the logs

What's the best way to test this MR?

Run GitLab Runner binary, from this branch, using the config.toml below. There shouldn't be any misleading error in the log

concurrent = 1 #00
check_interval = 1
log_level = "debug"
shutdown_timeout = 0

listen_address = ':9252'

[session_server]
  session_timeout = 1800

[[runners]]
  name = "ssh-runner"
  url = "https://gitlab.com"
  id = 0
  token = "glrt-REDACTED"
  token_obtained_at = 2023-10-19 12:56:59.157335
  token_expires_at = 0001-01-01T00:00:00Z
  executor = "ssh"
  [runners.cache]
    MaxUploadedArchiveSize = 0
  [runners.ssh]
    host = "***"
    port = "22"
    user = "admin"
    password = "***"

What are the relevant issue numbers?

close #31105 (closed)

Edited by Romuald Atchadé

Merge request reports