Skip to content

Convert custom kubernetes error to retryError

Nabil ZOUABI requested to merge nabil_zouabi/gitlab-runner:convert-custom-error-to-retry into main

What does this MR do?

In kubernetes context, when handling custom errors for retry, it's better to convert them to retryError as the rest of network errors defined in retryNetworkErrorsGroup

Why was this MR needed?

  • For more robust comparaison specially when calling the function isGroupError
  • To be able to use error comparaison based on error message containing the custom retry key as in strings.Contains(err.Error(), n.error.Error()) used by retryError Is method
  • Could be a possible reason for this issue #37388

What's the best way to test this MR?

  • Execute the unit tests in kubernetes_test.go file

What are the relevant issue numbers?

Edited by Nabil ZOUABI

Merge request reports