Skip to content

GitLab Next

gitlab-runner
gitlab-runner
Merged
Opened by Gasol Wu@GasolContributor2 of 4 tasks completed2/4 tasks

Fix missing VERSION on Mac build

What does this MR do?

Fix missing VERSION on Mac build

Why was this MR needed?

If gitlab-ci-multi-runner was build on Mac, Running command gitlab-ci-multi-runner --version will show empty version wihtout this MR.

gitlab-ci-multi-runner-linux-amd64 --version

Before

Version:
Git revision: e4814cdf
Git branch:   k8s1
GO version:   go1.7.5
Built:        Mon, 01 Jan 0001 00:00:00 +0000
OS/Arch:      linux/amd64

After

Version:      1.11.0~beta.30.ge4814cdf
Git revision: e4814cdf
Git branch:   k8s1
GO version:   go1.7.5
Built:        Mon, 01 Jan 0001 00:00:00 +0000
OS/Arch:      linux/amd64

Are there points in the code the reviewer needs to double check?

I checked existence of tr on Linux, FreeBSD and yes... Mac.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

No related issue