Skip to content

Hide docker executor init behind a feature flag

Axel von Bertoldi requested to merge avonbertoldi/docker-init-feature-flag into main

What does this MR do?

Hide the use of the init option when creating containers behind a feature flag in the the docker executor.

Why was this MR needed?

Over in !4446 (merged), we, among other things, added use of the Init option when creating containers in the docker executor. We did this for all containers, unconditionally. This was the wrong choice. It should have:

  • been done only for service and build images. The helper image doesn't need this.
  • been hidden behind a feature flag. Turns our there are a number of conditions where making tini-init PID 1 breaks things.

What's the best way to test this MR?

What are the relevant issue numbers?

Edited by Axel von Bertoldi

Merge request reports