Update gocloud.dev to v0.34.0
gocloud.dev v0.27.0 printed out some debug messages for Azure. This has since been fixed in v0.28.0: https://github.com/google/go-cloud/pull/3197
https://github.com/Azure/azure-sdk-for-go/pull/19010 moved many of the SAS functions into a separate package. Update the API accordingly.
v0.34.0 is required for Azure to work properly with SAS tokens due to https://github.com/google/go-cloud/issues/3283.
Why was this MR needed?
The URL for Azure caches was printed in the job logs
What's the best way to test this MR?
- Obtain an Azure Blob Storage container.
- Configure the runner cache:
[runners.cache]
type = "azure"
[runners.cache.azure]
AccountName = "<REDACTED>"
AccountKey = "<REDACTED>"
ContainerName = "test1"
StorageDomain = "blob.core.windows.net"
- Run a CI job with a cache:
image: ruby:latest
variables:
RUBY_VERSION: "2.7"
stages:
- test
test:
stage: test
script:
- date
- echo "hello2" > test.txt
cache:
paths:
- test.txt
In the latest GitLab Runner release, we see the URL:
Uploading cache.zip to azblob://test1/runner/eehdx1xw/project/2/default-non_protected
2023/10/24 16:16:55 azureblob: constructed service URL: https://REDACATED.blob.core.windows.net?se=2023-10-24T17%3A16%3A55Z&sig=oun%2F0xWQL3NDC83%2Bpd0181SGHBWfzwIr29OXhqkuwnw%3D&sp=w&spr=https&sr=b&st=2023-10-24T15%3A16%3A55Z&sv=2019-12-12
2023/10/24 16:16:55 azureblob.URLOpener: using SAS token and no other credentials
In this branch, those messages are gone.
What are the relevant issue numbers?
Edited by Stan Hu