Skip to content

Fix fallback_key for local cache

Andreas Bachlechner requested to merge andrbach/gitlab-runner:fix-local-cache-fallback-key into main

What does this MR do?

Fix fallback_key for local cache

The fallback_key was ignored before when a local cache was used. We now actually use the fallback keys if the desired cache key is not available. The fix needed two changes:

  • To trigger the use of the next allowed key, the cache_extractor needs to issue a message if the cache file does not exist.
  • addExtractCacheCommand needs to actually use the fallback key.

Why was this MR needed?

The fallback_key is ignored at the moment if a local cache is used.

What's the best way to test this MR?

Add a test with a local cache, a missing_key and a fallback_key. And check if the fallback_key is used.

What are the relevant issue numbers?

Fixes #27537 (closed)

Edited by Romuald Atchadé

Merge request reports