Skip to content

Add command in service containers for Kubernetes executor

Florian Aymard requested to merge faymard/gitlab-runner:kubernetes-services-set-command into main

What does this MR do?

This MR aims to add the Command argument in service containers when using the Kubernetes executor.

Why was this MR needed?

When migrating our CI infrastructure from Docker to Kubernetes executors, we found a regression on one of our pipelines.

As of now, the following snippet of code does not give the desired result anymore (having FF_KUBERNETES_HONOR_ENTRYPOINT=true):

  services:
    - name: k0sproject/k0s:v1.22.13-k0s.0
      alias: kubernetes-mock
      command:
        - k0s
        - controller
        - --enable-worker
        - --data-dir=/builds/k0s

The args given in the command argument are not pushed to the resulting Pod spec, hence breaking the existing pipeline.

What's the best way to test this MR?

Trigger a job on a Kubernetes executor and adding a service with a command: parameter. The args should be found in the resulting Pod spec.

What are the relevant issue numbers?

I was not able to find an opened issue about this problem.

Merge request reports