Skip to content

Fix flaky TestDockerPrivilegedServiceAccessingBuildsFolder

Arran Walker requested to merge ajwalker/docker-privileged-service-builds into main

What does this MR do?

Attempts to fix a flaky test by adding a retry loop.

Why was this MR needed?

The TestDockerPrivilegedServiceAccessingBuildsFolder integration uses docker:dind and relies on being able to pull busybox. For some reason, this occasionally returns an error:

docker run -v $(pwd):$(pwd) -w $(pwd) busybox touch test
Unable to find image 'busybox:latest' locally
docker: Error response from daemon: error parsing HTTP 408 response body: invalid character '<' looking for beginning of value: "<html><body><h1>408 Request Time-out</h1>\nYour browser didn't send a complete request in time.\n</body></html>\n".
See 'docker run --help'.

What's the best way to test this MR?

The flaky test should no longer occur, or if it does, is much much rarer than we see today.

What are the relevant issue numbers?

#30835 (closed)

Merge request reports