Skip to content

Fix flaky interactive terminal test - ensure terminal connected

Arran Walker requested to merge ajwalker/fix-flaky-interactive-test into main

What does this MR do?

In !3975 (merged), we hoped to fix the flaky interactive terminal test, but the wrong operator was used, so we weren't waiting correctly for the terminal to be connected.

Why was this MR needed?

Fixes flaky test.

What's the best way to test this MR?

Runing go test -run TestInteractiveTerminal/bash -v -tags integration ./executors/shell -count 10 a couple of times should continue to pass.

What are the relevant issue numbers?

#27579 (closed)

#30835 (closed)

Merge request reports