Skip to content

Make the `gitlab-runner register` command happen in a single operation

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/29670/delay-runner-registration into main

What does this MR do?

This MR changes the behavior of gitlab-runner register slightly when used with a new glrt- runner token:

  • runner is verified at the end of the gitlab-runner register command
  • logic to delete (API call unregister) when the process is aborted is disabled

Closes #29670 (closed)

Why was this MR needed?

This is needed in order to make the new registration process more intuitive for the user. By delaying the registration until the very end, we're able to provide feedback to the user on the GitLab UI exactly at the point where the runner was registered. We also avoid deleting a runner that has just been created in the UI, just because the user aborted the data entry on the Runner side.

What's the best way to test this MR?

I recorded a demo of the new behavior: https://www.loom.com/share/b0f77084fd704458990290ea2340c78c

What are the relevant issue numbers?

Closes #29670 (closed)

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports