Skip to content

Remove .runner_system_id from Docker images

Pedro Pombeiro requested to merge pedropombeiro/29646/remove-system_id-from-docker-images into main

What does this MR do?

This MR ensures that the .runner_system_id file doesn't get captured in the Docker image at creation time.

Why was this MR needed?

Each Docker container should generate its own .runner_system_id file. If the file is already present in the image, all containers will use the same ID.

What's the best way to test this MR?

  1. Open 2 terminal windows. In the first one, start the container: docker run --rm --name gitlab-runner gitlab/gitlab-runner (use the correct docker image). In the second terminal window, run docker exec gitlab-runner cat /etc/gitlab-runner/.runner_system_id and note the system ID;
  2. Stop the container (it will be removed automatically) and create it again. Run the docker exec gitlab-runner cat /etc/gitlab-runner/.runner_system_id command again, it should output a different system ID.

What are the relevant issue numbers?

Closes #29646 (closed)

Edited by Pedro Pombeiro

Merge request reports