Update pipeline to depend on runner-incept passing
What does this MR do?
This MR adds a depend
strategy to the runner-incept
downstream pipeline trigger. This way, if the runner-incept
pipeline fails, the gitlab-runner
pipeline that triggered it will also fail.
Why was this MR needed?
The gitlab-runner
pipeline currently ignores failures in the downstream runner-incept
pipeline. These tests are too important to ignore and failures have been missed in the past, leading to regressions going undiscovered for several weeks. Ignoring failing tests can lead to bugs, regression, technical debt, and a loss of trust in our processes. Failing tests should be promptly addressed to ensure reliable, secure, and maintainable code.
Example:
Last quarter an MR to upgrade the BurntSushi/toml version led to broken runner registration. The runner-incept
pipeline caught this bug right away, but none of us noticed every runner-incept
pipeline was failing for over 3 weeks.
What's the best way to test this MR?
What are the relevant issue numbers?
closes #29564 (closed)