Skip to content

Ignore glrt prefix for runner short token

Pedro Pombeiro requested to merge pedropombeiro/28913/fix-runner-short_sha into main

What does this MR do?

This MR removes the glrt- prefix from the short description if the runner token contains it.

Why was this MR needed?

To ensure that the token stays usable/relevant. An alternative approach would be to add 5 more characters to the short token in order to preserve the prefix, but I don't see a reason for the user to need to see the prefix.

What's the best way to test this MR?

It is hard to test this at the moment since the GitLab Rails app doesn't yet expose a way to create the new tokens. So knowledge of the Rails app or Postgres would be needed to change the local datastore. However, I tested it on my machine and can confirm the expected result:

header header
before change image
after change image

What are the relevant issue numbers?

#28913 (closed)

Edited by Pedro Pombeiro

Merge request reports