Skip to content

Upgrade github.com/BurntSushi/toml

Arran Walker requested to merge ajwalker/upgrade-toml-fixed into main

What does this MR do?

Upgrades the toml library, which supports time.Duration fields correctly (needed for new autoscaler configuration).

Why was this MR needed?

We previously upgraded this, but suffered a regression which has since been fixed upstream (https://github.com/BurntSushi/toml/pull/374). Unfortunately that merged fix is not yet part of a tagged release, but there doesn't appear to be much to worry about with the commits that are present in this specific revision.

What's the best way to test this MR?

The toml library we use is throughly tested, but apparently we're one of few users that embed structs, which is where the regression occurred and weirdly only on 32-bit systems. A test was added upstream.

What are the relevant issue numbers?

Edited by Arran Walker

Merge request reports