Skip to content

Use JobVariable.Value() for internal values

Arran Walker requested to merge 29575-internal-variable-value into main

What does this MR do?

Use JobVariable.Value() for internal values

Why was this MR needed?

file type variables were being expanded to the pathname, which makes sense when expanding a variable or using a variable in the context of the job environment, but doesn't make sense when Runner knows it needs the variable's contents, and not the pathname.

This change means that most internal values can now be of type file, where they will be written to a file in the job environment, but it won't matter to how Runner uses them internally. This is identical to the behaviour prior to 15.7.

What's the best way to test this MR?

For the majority of users, this has become an issue when DOCKER_AUTH_CONFIG has been a file-type variable, so that would be a good place to test this.

What are the relevant issue numbers?

Closes #29575 (closed)

Merge request reports