Skip to content

SPIKE: Apply user pod spec to internal pod spec

Georgi N. Georgiev requested to merge k8s-patch-pod-spec into main

What does this MR do?

Continuation of !3114 (merged)

Info on strategic merge patch: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-api-machinery/strategic-merge-patch.md Function used to perform the patch: https://github.com/kubernetes/apimachinery/blob/master/pkg/util/strategicpatch/patch.go

Why was this MR needed?

To explore option #2 from !3114 (comment 709326493)

What's the best way to test this MR?

In the kubernetes section of your config.toml you'll have a pod_spec that will be a JSON or YAMl. See the tests to get an idea https://gitlab.com/gitlab-org/gitlab-runner/blob/f32e817977a6c37867c2d163940c7b79ea47b6df/executors/kubernetes/kubernetes_test.go#L5720-5720.

What are the relevant issue numbers?

Edited by Georgi N. Georgiev

Merge request reports