Skip to content

Draft: Consolidate code to capture helper service logs into job/tasks main trace log

Axel von Bertoldi requested to merge avonbertoldi/2119/capture-service-logs-k8s-consolidate into main

What does this MR do?

Following on !3551 (closed) and !3564 (closed), the MR consolidates the code that is similar/common between the two packages (of which there is a lot).

Why was this MR needed?

DRY!!! Basically, it turns out that the approach and code to capturing service container logs in the docker and kubernetes end up being very similar. The differences amount to:

  • how the names of the containers are collected
  • how we connect to the containers to capture their logs

May as well consolidate the similar code and remove some duplication. This should make it less work if/when we decide to implement streaming the logs to an alternate destination (i.e. individual files for each container)

What's the best way to test this MR?

Same testing method mentioned in !3551 (closed) and !3564 (closed), plus the integration test added in those MRs.

What are the relevant issue numbers?

Notes

  • Best reviewed commit-at-a-time.
  • This MR builds on !3551 (closed) and !3564 (closed), so includes the changes from those MRs. Start reviewing at [common] Consolidate service container log capture code into common package
Edited by Axel von Bertoldi

Merge request reports