Skip to content

zip_extract: Remove duplicate Chmod

Jonas Hahnfeld requested to merge (removed):skip-symlink-chmod into main

What does this MR do?

Avoid changing the mode of symlinks when extracting archives.

Why was this MR needed?

Files and directories are already created with the correct permissions. This leaves symlinks, but for those os.Chmod is documented as follows: "If the file is a symbolic link, it changes the mode of the link's target." This is not what gitlab-runner should do when extracting archives that could link to files in the repo or even the system, so just remove the Chmod and fold the two loops.

What are the relevant issue numbers?

Closes #3354, #27496 (closed)

Edited by Jonas Hahnfeld

Merge request reports