Skip to content

Push image on registry during release stage only when enabled

Romuald Atchadé requested to merge ci-do-not-push-on-registry-when-disabled into main

What does this MR do?

This MR allows images to be pushed on the registry only if enabled

Why was this MR needed?

At the moment, the GitLab Runner images published on the AWS ECR registry have been deactivated (PUSH_TO_ECR_PUBLIC: false). However, the CI still tries to push to images resulting in the failure of the related job as it can be seen in the Release stage of those pipelines (bleeding edge helper docker images jobs):

This MR fixes the issue so the pipeline doesn't fail anymore.

What's the best way to test this MR?

To test this MR, the following variables have been updated in the Release stage for the development helper docker images jobs.

  • PUBLISH_IMAGES set to true
  • PUSH_TO_ECR_PUBLIC kept to false

PS: The error wasn't occurring in the development helper docker images jobs because of PUBLISH_IMAGES set to false

Test pipeline and related commit

In the following logs, we can see that there is no failure caused by an attempt to push on AWS ECR

What are the relevant issue numbers?

close #29170 (closed)

Edited by Romuald Atchadé

Merge request reports

Loading