Skip to content

Update minio-go dependency to fix FIPS endpoints

Stan Hu requested to merge sh-update-minio-go into main

What does this MR do?

This merge request updates the minio-go module.

Diff: https://github.com/minio/minio-go/compare/f2d40be3e82f..47da873ffd36

Why was this MR needed?

Previously minio-go did not properly detect the region when AWS FIPS endpoint were used. https://github.com/minio/minio-go/pull/1663 fixes this issue.

What's the best way to test this MR?

With an S3 bucket, modify these settings accordingly:

Type = "s3"
Shared = true
[runners.cache.s3]
  ServerAddress = "s3-fips.us-east-1.amazonaws.com"
  AccessKey = "<AWS_ACCESS_KEY_ID>"
  SecretKey = "<AWS_SECRET_ACCESS_KEY>"
  BucketName = "foobar-bucket"
  BucketLocation = "us-east-1"

On master, this fails:

Creating cache test-protected...
test.txt: found 1 matching files and directories   
Uploading cache.zip to https://foobar-bucket.s3-fips.us-west-2.amazonaws.com/project/22/test-protected 
FATAL: received: 400 Bad Request

The upload should succeed:

Creating cache test-protected...
test.txt: found 1 matching files and directories   
Uploading cache.zip to https://foobar-bucket.s3-fips.us-west-2.amazonaws.com/project/22/test-protected

What are the relevant issue numbers?

Relates to #29112 (closed)

Edited by Stan Hu

Merge request reports