Skip to content

Update runner registration failure log message

Jamie Reid requested to merge remove-network-speculation into main

What does this MR do?

As discussed in #28919 (comment 859410013), the log message that gitlab-runner provides when registration of the runner against an instance fails due to a bad registration token currently appears as:

ERROR: Registering runner... forbidden (check registration token)  runner=fail
PANIC: Failed to register the runner. You may be having network problems.

This MR removes the "You may be having network problems." part of the logged string.

Why was this MR needed?

The speculative "You may be having network problems." creates a red herring for someone trying to debug a runner issue. In one path, the runner has received an HTTP/403 Unauthorized error. It's definitely not networking. Sometimes, networking may be the culprit, but without further logic, it's not helpful to speculate.

What's the best way to test this MR?

Attempt to register a runner but provide a bad token

Edited by Jamie Reid

Merge request reports