Skip to content

Make ssh command/executor shell agnostic

Arran Walker requested to merge ajwalker/ssh-shell-agnostic into main

What does this MR do?

Removes the ssh executor/command executor from needing to know about shells or escaping rules.

Why was this MR needed?

Overall plans of adding newer remote executors and better executor interfaces means shell logic should stay in the shell package.

What's the best way to test this MR?

For Bash (which this mostly affects), the test can be used with the previous implementation of GetConfiguration (if you comment out the cmdline check).

Other than GetConfiguration, everything else should stay the same, we're mostly just moving things around.

What are the relevant issue numbers?

Edited by Arran Walker

Merge request reports