Skip to content

Upgrade fastzip to v0.1.8

What does this MR do?

Why was this MR needed?

Fastzip was creating malformed zip files.

What's the best way to test this MR?

  • Create a job with a large artifact and it should no longer be invalid.
  • Fastzip has test coverage and the regression has been fixed: https://github.com/saracen/fastzip/actions/runs/1878454823
  • Trigger failure with test using old dependency:
    # works fine
    go test -v -run TestZipArchiveExtract ./commands/helpers
    
    # downgrade to a non-fixed fastzip + a non-fixed klauspost/compress
    go get -u github.com/saracen/fastzip@v0.1.6 github.com/klauspost/compress@v1.13.6 
    
    # test should now fail
    go test -v -run TestZipArchiveExtract ./commands/helpers

What are the relevant issue numbers?

Closes #28903 (closed)

Edited by Arran Walker

Merge request reports

Loading