Make use of build requests/limits for build permission init container
What does this MR do?
Add request/limit to init containers
This MR finishes the work started by @tomas.kohout1995 in !3306 (closed)
Why was this MR needed?
Currently it's not possible to use gitlab runner when resourcequotas are present in namespace, where jobs should run.
What's the best way to test this MR?
Create ns with resourcequotas and see if job pods are correctly created.
What are the relevant issue numbers?
close #28098 (closed)
Merge request reports
Activity
changed milestone to %14.8
assigned to @ratchade
mentioned in merge request !3306 (closed)
added 30 commits
-
4538ebd9...fb049b6c - 26 commits from branch
main
- 41df5599 - Make use of build requests/limits for build permission init container.
- c0b16af5 - An unit test for resources in init container.
- a709112b - An unit test for resources in init container.
- 05145d0b - Remove unnecessary line
Toggle commit list-
4538ebd9...fb049b6c - 26 commits from branch
- Resolved by Romuald Atchadé
@ajwalker Would you mind reviewing this MR please
🙇🏿 A bit of context:
This MR aims to fix the issue #28098 (closed) but I unfortunately was not able to reproduce it. The fix was provided by @tomas.kohout1995 and I am picking it up as he is currently in vacation (all of the job has been done by him, I just deleted an empty line
😅 ). The community MR can be found here !3306 (closed)
requested review from @ajwalker
added 1 commit
- ce773de7 - Use helper limits/requests instead of build ones
Back to you
🏓 @ajwalker
added 1 commit
- 423acf6f - Use helper (instead of build) limits/requests for init container
enabled automatic add to merge train when the pipeline for f49b9fec succeeds
mentioned in commit fa9d8b21
added featureaddition label
added typefeature label
mentioned in issue #29169