Skip to content

Expose fastzip configuration options

build on top of !3403 (merged)

What does this MR do?

Exposes specific fastzip options

Why was this MR needed?

Whilst the default fastzip options are typically fine, they do need to be exposed.

  • It's not always safe to assume the temporary directory (a tmpfs) has enough capacity (as is the case for the issue referened)
  • For a server with 128 cores, the default NumCPU() for concurrency might not work well (it has memory and disk IO ramifications too).

What's the best way to test this MR?

There's a test that checks solely whether options are being passed through. It does this by choosing options that are entirely invalid and checks that fastzip operations then fail. We don't need to check that any succeed, only that values are being passed through.

The same settings could be done as part of a manual QA if required, but probably not necessary.

What are the relevant issue numbers?

Closes #28189 (closed)

Edited by Arran Walker

Merge request reports