Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gitlab-runner gitlab-runner
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,506
    • Issues 2,506
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • gitlab-runnergitlab-runner
  • Merge requests
  • !3130

Expose fastzip configuration options

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Arran Walker requested to merge 28189-make-fastzip-stagedirectory-configurable into main Sep 12, 2021
  • Overview 23
  • Commits 1
  • Pipelines 17
  • Changes 3

⚠ build on top of !3403 (merged)

What does this MR do?

Exposes specific fastzip options

Why was this MR needed?

Whilst the default fastzip options are typically fine, they do need to be exposed.

  • It's not always safe to assume the temporary directory (a tmpfs) has enough capacity (as is the case for the issue referened)
  • For a server with 128 cores, the default NumCPU() for concurrency might not work well (it has memory and disk IO ramifications too).

What's the best way to test this MR?

There's a test that checks solely whether options are being passed through. It does this by choosing options that are entirely invalid and checks that fastzip operations then fail. We don't need to check that any succeed, only that values are being passed through.

The same settings could be done as part of a manual QA if required, but probably not necessary.

What are the relevant issue numbers?

Closes #28189 (closed)

Edited May 09, 2022 by Arran Walker
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 28189-make-fastzip-stagedirectory-configurable