refactor: remove osext dependency
What does this MR do?
Remove osext.
Why was this MR needed?
As of go 1.8+ Executable
is part of the std lib and osext is deprecated ( see https://github.com/kardianos/osext/issues/20 and https://github.com/kubernetes/kubernetes/issues/80127 )
What's the best way to test this MR?
What are the relevant issue numbers?
Could potentially fix #1246 (closed)
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
Some contributions require several iterations of review and we try to mentor contributors during this process. However, we understand that some reviews can be very time consuming. If you would prefer for us to continue the work you've submitted now or at any point in the future please let us know.
If you're okay with being part of our review process (and we hope you are!), there are several initial checks we ask you to make:
- The merge request description clearly explains:
- The problem being solved.
- The best way a reviewer can test your changes (is it possible to provide an example?).
- If the pipeline failed, do you need help identifying what failed?
- Check that Go code follows our Go guidelines.
- Read our contributing to GitLab Runner document.
This message was generated automatically. You're welcome to improve it.
- The merge request description clearly explains:
added Community contribution label
@gitlab-bot label grouprunner
added grouprunner label
added 1st contribution label
Setting label(s) Category:Runner devopsverify sectionops based on grouprunner.
added [Deprecated] Category:Runner devopsverify sectionops labels
mentioned in issue gitlab-org/quality/triage-reports#4349 (closed)
mentioned in issue gitlab-com/www-gitlab-com#12305 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4539 (closed)
added 107 commits
-
0285d448...72d757b6 - 106 commits from branch
gitlab-org:main
- c80453e0 - refactor: remove osext dependency
-
0285d448...72d757b6 - 106 commits from branch
@ajwalker I figure you have a lot of context in this area.
requested review from @ajwalker
mentioned in issue gitlab-org/quality/triage-reports#4700 (closed)
added maintenancerefactor label
changed milestone to %14.4