Skip to content

Update rules for windows tests to fix docs pipeline

Marcel Amirault requested to merge update-runner-docs-pipeline-rule into main

What does this MR do?

After we updated the pipeline to work with changes:, the first docs-only MRs merged caused pipeline failures due to missing jobs: https://gitlab.com/gitlab-org/gitlab-runner/-/pipelines/343819326

This was caused by two windows test jobs running in all pipelines on main, but not their dependencies:

  • Run on main in all cases (no changes: config):
    • windows 2004 integration tests:
    • windows 20H2 integration tests:
  • Only run on main for the changes: listed in .code-backstage-patterns:
    • integration test definitions:
    • clone test repo:

If you merged a docs-only MR, the first two windows test jobs are included in the main pipeline, but they need the last two jobs, which are not included due to their changes:, and the pipeline fails to be created.

The two windows test jobs get their rules: logic from .windows test, which uses .rules:default-branch-only. I checked that rule, and it is not used anywhere else in the pipeline, it's solely for these windows tests, and safe to update.

To make it clear what this rule is now doing, I also renamed it to .rules:default-branch-only:no_docs (to match the other no_docs rules configs).

Edited by Marcel Amirault

Merge request reports