Make timeouts fail the Windows unit tests (!3019) · Merge requests · GitLab.org / gitlab-runner · GitLab

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/27474-fail-windows-builds-returning-exit-code-2 into main Jul 07, 2021

What does this MR do?

This MR makes the Windows tests only ignore failures with exit code 1. A job timeout should return exit code 2, so it should fail the job.

Why was this MR needed?

We can see in this job that while it timed out, it was considered as an ignored failure.

What's the best way to test this MR?

Make the timeout for Windows tests very short, it should make the pipeline fail, not just the check windows ... test failures jobs.

What are the relevant issue numbers?

Closes #27474 (closed)